Remove old way of HALT Reboot method#1
Merged
ndas7 merged 1 commit intondas7:gnoi_rebootfrom Feb 14, 2025
Merged
Conversation
vvolam
force-pushed
the
gnoi_reboot_halt
branch
from
3d84fa4 to
d7ce532
Compare
hdwhdw
approved these changes
Jan 30, 2025
hdwhdw
left a comment
hdwhdw
left a comment
There was a problem hiding this comment.
LGTM but can we leave some trace in the PR description for why we are doing this? Maybe also link to the PR that add the new method?
Author
Since this will be stacked with the base ndas7:gnoi_reboot PR, it goes along with the new PR where the new method is added. |
6 tasks
vvolam
force-pushed
the
gnoi_reboot_halt
branch
from
d7ce532 to
65c3190
Compare
vvolam
force-pushed
the
gnoi_reboot_halt
branch
from
65c3190 to
552c627
Compare
Owner
|
Please resolve conflicts. |
vvolam
force-pushed
the
gnoi_reboot_halt
branch
from
552c627 to
5920f57
Compare
Author
@ndas7 Its fixed. Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why I did it
How I did it
How to verify it
Which release branch to backport (provide reason below if selected)
Description for the changelog
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)